Simon Pascal Klein
klepas

Organizations

@fonts @makehackvoid
Aug 30, 2016
@klepas
Provide guidance on writing headings to be contextually meaningful when read stand-alone
Aug 30, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#318
@klepas

@joolswood it was also the jargon-ised wording. I reckon we should try improve on it. I think we can avoid linking to the tools we use too, since w…

Aug 30, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#317
@klepas

LGTM.

Aug 30, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#315
@klepas

LGTM. Nice.

Aug 30, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#314
@klepas

LGTM. Happy to leave the heading–index link hierarchies a bit buggered and do a separate fix for that like you suggested @petronbot.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#306
@klepas

@petronbot I updated the branch. If we’re willing to live with the new form button error + the few visual bugs I’m OK to merge this in. (Also happy…

Aug 29, 2016
@klepas
  • @klepas 73c274f
    Merge branch 'develop' into feature/DESIGN-382_manual-test-plan
  • @TrebBrennan 490b9f6
    Merge pull request #305 from AusDTO/bugfix/DESIGN-377_vert-list-width
  • 5 more commits »
Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#305
@klepas

Back to you @TrebBrennan.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#306
@klepas

I’ll chuck up a bug ticket.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#306
@klepas

Nice. (: LGTM. We introduced one more a11y template bug (zoo.html output, same form lacking a submit button bug — happy to live with that). Only th…

Aug 29, 2016
@klepas
  • @klepas 7703a0d
    Fixes pa11y bugs in zoo.html.
Aug 29, 2016
@klepas
  • @klepas ce49250
    Logs edits for flexbox -> Neat grid vertical list rewrite.
Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#305
@klepas

LGTM. (: My edit: footer-top now uses span-columns instead of flexboxes too — supp. for IE9/10.

Aug 29, 2016
@klepas
  • @klepas b037e5b
    Vertical list rewritten to use span-columns function instead of flexb…
Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#305
@klepas

Gonna review this now.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#311
@klepas

Gonna fix for correct input from users later (card in Jira thx to Petra). LGTM.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#311
@klepas

@petronbot I added some in-line comments. Need to resolve re. the pattern="[0-9]* thing, but otherwise LGTM.

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#311
@klepas

Do we need to remove the ref to "pattern="[0-9]*" in our documentation? We should also test whether this removes iOS support for the number pad?

Aug 29, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#311
@klepas

I think this one was my bad.

Aug 29, 2016
@klepas
  • @klepas 604faf0
    Fixes h2-h3 markup bug in groups-links hbs.
Aug 26, 2016
Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#288
@klepas

*Nod* Works with me. (:

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#296
@klepas

LGTM.

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#288
@klepas

Please see my inline comment about the legislation ref. Added an inline comment on this. (: I'm uncertain about line 42 @klepas - JavaScript and…

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#288
@klepas

I added this since we’ve referenced our accessibility obligations previously, whereas the browser support philosophy/policy we’re doing here — I fe…

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#296
@klepas

do we want to go back to Andrew before we merge? I think he’d probably agree with us, and I think we’re all on the same page wrt. this guidance i…

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#296
@klepas

@joolswood @TrebBrennan If we want to offer leading guidance we might then want to mention the four vars we have for it, and ask people to use the …

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#296
@klepas

@joolswood Hey, other than a minor comment I made re line-height/leading guidance, this LGTM.

Aug 23, 2016
klepas commented on pull request AusDTO/gov-au-ui-kit#296
@klepas

This shouldn’t be necessary, since our setup provides it; other devs extending UI-Kit would only be overwriting it, which they shouldn’t.

Aug 23, 2016
klepas opened pull request AusDTO/gov-au-ui-kit#296
@klepas
DESIGN-335: fonts guidance
2 commits with 18 additions and 2 deletions