Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use BigNumber .minus #165

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
1 participant
@satello
Copy link
Member

commented Aug 9, 2018

Subtracting bigNumbers leads to rounding errors. Must use built in .minus

@satello satello merged commit 76f457e into develop Aug 9, 2018

1 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls First build on fix/rounding_pnk_error at 16.412%
Details

@satello satello deleted the fix/rounding_pnk_error branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.