From 75f6304ab2909aa19f6eaea1966114f5858c4515 Mon Sep 17 00:00:00 2001 From: Shebin John Date: Sun, 19 Apr 2020 09:44:31 +0530 Subject: [PATCH 1/2] Added RAB Pragma to Arbitration Standard Contracts --- contracts/standard/arbitration/Arbitrable.sol | 11 +++++++---- contracts/standard/arbitration/Arbitrator.sol | 11 +++++++---- contracts/standard/arbitration/IArbitrable.sol | 11 +++++++---- 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/contracts/standard/arbitration/Arbitrable.sol b/contracts/standard/arbitration/Arbitrable.sol index 4e01152c..80f6292a 100644 --- a/contracts/standard/arbitration/Arbitrable.sol +++ b/contracts/standard/arbitration/Arbitrable.sol @@ -1,7 +1,9 @@ -/** - * @title Arbitrable - * @author Clément Lesaege - - * Bug Bounties: This code hasn't undertaken a bug bounty program yet. + /** + * @authors: [@clesaege] + * @reviewers: [@remedcu] + * @auditors: [] + * @bounties: [] + * @deployments: [] */ pragma solidity ^0.4.15; @@ -9,6 +11,7 @@ pragma solidity ^0.4.15; import "./IArbitrable.sol"; /** @title Arbitrable + * @author Clément Lesaege - * Arbitrable abstract contract. * When developing arbitrable contracts, we need to: * -Define the action taken when a ruling is received by the contract. We should do so in executeRuling. diff --git a/contracts/standard/arbitration/Arbitrator.sol b/contracts/standard/arbitration/Arbitrator.sol index c732788b..c7b5d934 100644 --- a/contracts/standard/arbitration/Arbitrator.sol +++ b/contracts/standard/arbitration/Arbitrator.sol @@ -1,7 +1,9 @@ -/** - * @title Arbitrator - * @author Clément Lesaege - - * Bug Bounties: This code hasn't undertaken a bug bounty program yet. + /** + * @authors: [@clesaege] + * @reviewers: [@remedcu] + * @auditors: [] + * @bounties: [] + * @deployments: [] */ pragma solidity ^0.4.15; @@ -9,6 +11,7 @@ pragma solidity ^0.4.15; import "./Arbitrable.sol"; /** @title Arbitrator + * @author Clément Lesaege - * Arbitrator abstract contract. * When developing arbitrator contracts we need to: * -Define the functions for dispute creation (createDispute) and appeal (appeal). Don't forget to store the arbitrated contract and the disputeID (which should be unique, use nbDisputes). diff --git a/contracts/standard/arbitration/IArbitrable.sol b/contracts/standard/arbitration/IArbitrable.sol index d7cdeb3c..a5d5d44e 100644 --- a/contracts/standard/arbitration/IArbitrable.sol +++ b/contracts/standard/arbitration/IArbitrable.sol @@ -1,7 +1,9 @@ -/** - * @title IArbitrable - * @author Enrique Piqueras - - * Bug Bounties: This code hasn't undertaken a bug bounty program yet. + /** + * @authors: [@epiqueras] + * @reviewers: [@remedcu] + * @auditors: [] + * @bounties: [] + * @deployments: [] */ pragma solidity ^0.4.15; @@ -9,6 +11,7 @@ pragma solidity ^0.4.15; import "./Arbitrator.sol"; /** @title IArbitrable + * @author Enrique Piqueras - * Arbitrable interface. * When developing arbitrable contracts, we need to: * -Define the action taken when a ruling is received by the contract. We should do so in executeRuling. From 8b70f50b05547becb24a29030cd1f5303ef3ae3f Mon Sep 17 00:00:00 2001 From: Shebin John Date: Sun, 19 Apr 2020 09:47:42 +0530 Subject: [PATCH 2/2] Comment Updated --- contracts/standard/arbitration/Arbitrator.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/contracts/standard/arbitration/Arbitrator.sol b/contracts/standard/arbitration/Arbitrator.sol index c7b5d934..7ce7d806 100644 --- a/contracts/standard/arbitration/Arbitrator.sol +++ b/contracts/standard/arbitration/Arbitrator.sol @@ -39,6 +39,7 @@ contract Arbitrator { /** @dev To be raised when a dispute can be appealed. * @param _disputeID ID of the dispute. + * @param _arbitrable The contract which created the dispute. */ event AppealPossible(uint indexed _disputeID, Arbitrable indexed _arbitrable);