Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian localization for version 2.4.5 #174

Merged
merged 5 commits into from Jul 26, 2019

Conversation

@Nesferatum
Copy link
Contributor

commented Jul 17, 2019

Hey.

I liked this addon, I use it and decided to make Russian localization for it. Most texts are translated correctly, but there are some errors in the translation. Currently, the Russian language is not officially supported by the game client, and some functions that work correctly for official languages ​​does not work in Russian.

For example: zo_strformat("<<m:1>>", GetString ("SI_ITEMFILTERTYPE", .....)). If the Russian word has the same singular and plural number, then you will get the Russian word at the end of which the letter S is added. And this spoils the quality of the translation. This is especially noticeable in the PABanking submenu: Glyphs, Potions and Poisons, Food and Drinks, Trophies and Intricate items. Almost all of the items in this submenu have the letter S in the translation at the end of the name.

The same goes for PAJunk - Collectibles, Weapons, Armor and Jewelry (submenu headers and items) and Stolen items (only items Armor, Weapons and Jewelry), and if I can replace the headings in the localization file, then I cannot change the items in the submenu, because they do not have a variable to translate in the source language.

A replacement for plural to singular - zo_strformat("<<s:1>>", GetString ("SI_ITEMFILTERTYPE", .....)) - could help, but I'm not sure that this will work correctly for other languages. Also, zo_strformat(GetString("SI_PA_ITEMTYPE", ITEMTYPE_.....), 2) works correctly because the singular and plural are present in translations.

I also corrected the translation of the submenu heading Glyphs in all languages. I update fork the repository and try to quickly make new translations if they need. And I can make pull request if you need it.

@Nesferatum Nesferatum changed the title Russian translation Russian localization for version 2.4.5 Jul 17, 2019

@klingo
Copy link
Owner

left a comment

Oh wow, thanks so much for these positive words and all your effort to do the translations!
I was off for a few days and need to implement some bugfixes first; but once that is done I will merge this PR and prepare a new release.

@klingo klingo merged commit 198fe95 into klingo:master-v2 Jul 26, 2019

@klingo klingo added this to the 2.4.8 milestone Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.