Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint with /style.json #154

Closed
klokan opened this issue Apr 21, 2017 · 1 comment
Closed

Endpoint with /style.json #154

klokan opened this issue Apr 21, 2017 · 1 comment
Assignees

Comments

@klokan
Copy link
Member

klokan commented Apr 21, 2017

It may make sense to reconsider the endpoints exposed by the server.

TileJSON for /styles/{name}.json
GL Style JSON /styles/{name}/style.json
XYZ tiles at /styles/{name}/z/x/y.png

Then we are more aligned to GL Style Package spec and the way how we store GL styles in GitHub and zip files on releases, for example, https://github.com/openmaptiles/osm-bright-gl-style

Related to:
http://tileserver.readthedocs.io/en/latest/endpoints.html

To be discussed.

@petrsloup
Copy link
Member

petrsloup commented Jun 15, 2017

If we are going to make this change, it should be part of v2 since it breaks compatibility quite significantly (the v2 branch already contains upgrade from node 4 to node 6.).

Notes:

  • "GL Style JSON /styles/{name}/style.json" no problem
  • "XYZ tiles at /styles/{name}/z/x/y.png" no problem
  • "TileJSON for /styles/{name}.json" this is where the collision happens (and compatibility breaks)
    • v1 has style JSON on this URL
    • v2 will have TileJSON here

Solutions:

  • a) Just change it
  • b) Opt-in option (newUrls: true)
  • c) Opt-out option (legacyUrls: true)

To be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants