New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to POD, fix pod and add test #2

Merged
merged 5 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@lharey
Contributor

lharey commented Jan 20, 2017

Hi

As per our emails re the Pull Request challenge.
This fixes the cpants warning about license and fixes the pod error in pmake.
I've also added a pod test and also fixed an error with an incorrectly named file in the manifest

Regards
Lisa

@klp2

Thanks! There are a couple of perl critic test failures that I think are easy to fix, and then it should be good to merge.

@@ -0,0 +1,11 @@
#!/usr/bin/env perl

This comment has been minimized.

@klp2

klp2 Jan 20, 2017

Owner

Can you add use strict/use warnings here?

@klp2

klp2 Jan 20, 2017

Owner

Can you add use strict/use warnings here?

Show outdated Hide outdated t/97-pod.t
#!/usr/bin/env perl
use Test::More;
eval "use Test::Pod 1.00";

This comment has been minimized.

@klp2

klp2 Jan 20, 2017

Owner

Can you add a ##no critic before the eval?

@klp2

klp2 Jan 20, 2017

Owner

Can you add a ##no critic before the eval?

@lharey

This comment has been minimized.

Show comment
Hide comment
@lharey

lharey Jan 20, 2017

Contributor

oops sorry I always use strict/warnings don't know why I missed it here.

Fixed now

Contributor

lharey commented Jan 20, 2017

oops sorry I always use strict/warnings don't know why I missed it here.

Fixed now

@klp2

klp2 approved these changes Jan 20, 2017

@klp2

This comment has been minimized.

Show comment
Hide comment
@klp2

klp2 Jan 20, 2017

Owner

Thanks for that. It looks like there are still some tidy related test failures. If you have https://metacpan.org/pod/distribution/Code-TidyAll/bin/tidyall installed or don't mind installing it, can you run tidyall over your branch? If you would prefer not to install it, let me know and I can just merge and tidy it up afterwards.

Owner

klp2 commented Jan 20, 2017

Thanks for that. It looks like there are still some tidy related test failures. If you have https://metacpan.org/pod/distribution/Code-TidyAll/bin/tidyall installed or don't mind installing it, can you run tidyall over your branch? If you would prefer not to install it, let me know and I can just merge and tidy it up afterwards.

@lharey

This comment has been minimized.

Show comment
Hide comment
@lharey

lharey Jan 23, 2017

Contributor

Hi

I have now run tidyall on the files and updated

Regards
Lisa

Contributor

lharey commented Jan 23, 2017

Hi

I have now run tidyall on the files and updated

Regards
Lisa

@klp2 klp2 merged commit 7730ffb into klp2:master Jan 23, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@klp2

This comment has been minimized.

Show comment
Hide comment
@klp2

klp2 Jan 23, 2017

Owner

Cool, thank you!

Owner

klp2 commented Jan 23, 2017

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment