Modernize the build a bit #4

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
2 participants
@genio
Contributor

genio commented Mar 4, 2017

Hi,

I received your dist in this month's CPAN PR Challenge. When looking through the docs and examples, I noticed a few things that could be fixed and one of the RT tickets that stated that your git repo came over in the dist.

  • Cleanup the Makefile.PM to be a bit more modern.
  • Update META.json to be more modern.
  • Remove .git repo files from build
  • Split the multiple packages in Make.pm into their own files

Thanks,
Chase

Fix META information to modernize Makefile.PL and META.JSON. Remove .…
…git info from the build. Split out Make,pm into their proper module files
@klp2

This comment has been minimized.

Show comment
Hide comment
@klp2

klp2 Apr 15, 2017

Owner

My apologies for the delayed reply.

It looks like this ends up exposing a bunch of Perl Critic errors; I don't think many if any of them are new, they just aren't suppressed any longer. If you haven't already moved along, do you want to take a crack at fixing some of those? If you have already moved along let me know and I'll try to find some time to do so.

Owner

klp2 commented Apr 15, 2017

My apologies for the delayed reply.

It looks like this ends up exposing a bunch of Perl Critic errors; I don't think many if any of them are new, they just aren't suppressed any longer. If you haven't already moved along, do you want to take a crack at fixing some of those? If you have already moved along let me know and I'll try to find some time to do so.

@klp2 klp2 merged commit ec7edfa into klp2:master Jun 20, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment