Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on the removed HEALTHCHECK #19

Closed
larssb opened this issue Apr 11, 2020 · 2 comments
Closed

Question on the removed HEALTHCHECK #19

larssb opened this issue Apr 11, 2020 · 2 comments

Comments

@larssb
Copy link

larssb commented Apr 11, 2020

Hi @klutchell,

As it can be seen in commit remove drill and internal healthcheck the HEALTHCHECK was removed. My question is, why was it removed?
The reason I ask is because I'm trying to use this dnscrypt-proxy container image and it uses the same HEALTHCHECK.
But, if the drill cmd is taking a long time to complete the time out kicks in and that seems to leave drill processes in a zombie state. Causing a resource limit issue. As zombie processes still counts against the max user open processes. And that number is at some point met.
So some background on why it was removed would be lovely.

Thank you very much and a Happy Easter

@klutchell
Copy link
Owner

Hmm, my commit message isn't very helpful is it.

If my memory serves, it was just a matter of keeping the image as simple as possible, and as part of that I would prefer it be up to the user to set a healthcheck at runtime if they want one, as long as the required components are present to do so.

In fact, I probably considered adding an example to run with a healthcheck in the README but forgot to add it. Since there are some cases where a healthcheck may be undesirable or not work at all, I'd rather it be opt-in only :)

@larssb
Copy link
Author

larssb commented Apr 12, 2020

Hi @klutchell,

Thank you for replying so quickly. I'm totally okay with your though on letting the user just providing a HEALTHCHECK at runtime.

Thank you and stay home and safe 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants