Use parse in @inheritParams. Closes #236

NEWS.md

@@ -63,6 +63,9 @@ Roxygen2 4.0.0 is a major update to roxygen2 that makes provides enhanced error
 
 ## Bug fixes and minor improvements
 
+* Better parsing of non-syntactic function names in other packages when
+  used in `@inheritParams` (#236).
+
 * Deprecated arguments to `roxygenise()` (`roxygen.dir`, `copy.package`,
   `overwrite`, `unlink.target`) removed.
 

R/inherit-params.R

@@ -37,9 +37,11 @@ find_params <- function(inheritor, topics, name_lookup) {
 
   if (has_colons) {
     # Reference to another package
-    pieces <- strsplit(inheritor, "::", fixed = TRUE)[[1]]
-    params <- rd_arguments(get_rd(pieces[2], pieces[1]))
+    parsed <- parse(text = inheritor)[[1]]
+    pkg <- as.character(parsed[[2]])
+    fun <- as.character(parsed[[3]])
 
+    params <- rd_arguments(get_rd(fun, pkg))
   } else {
     # Reference within this package
     rd_name <- names(Filter(function(x) inheritor %in% x, name_lookup))

tests/testthat/test-param.R

@@ -93,3 +93,8 @@ test_that("data objects don't get params", {
   expect_equal(get_tag(out, "param"), NULL)
 
 })
+
+test_that("find_params parses input", {
+  params <- find_params("utils::`?`", NULL, NULL)
+  expect_equal(names(params), c("topic", "type"))
+})