add e2e test for service entry with inlined workload entry #1041
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Codecov ReportAttention: Patch coverage is
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| } else if port.TargetPort == 0 { | ||
| // NOTE: Target port could be unset in servicen entry, in which case it should | ||
| // be consistent with the Service Port. | ||
| newValue.TargetPort[i] = nets.ConvertPortToBigEndian(port.ServicePort) |
There was a problem hiding this comment.
I can see istio has set the traget port
Which istio version are you using
There was a problem hiding this comment.
Looks this is set since istio 1.23
There was a problem hiding this comment.
oh, I tested it with istio 1.22
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
add e2e test for service entry with inlined workload entry
3 participants
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1037
Special notes for your reviewer:
Does this PR introduce a user-facing change?: