-
Notifications
You must be signed in to change notification settings - Fork 135
eBPF unit test: Remove expired codes & Add framework doc #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zhenxiong Tian <sancpp@qq.com>
Signed-off-by: Zhenxiong Tian <sancpp@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes outdated eBPF unit test code and adds documentation for the new eBPF unit test framework.
- Removed several expired test files (xdp_test.c, run_tests.sh, common.h, Makefile)
- Added comprehensive framework documentation in docs/ebpf_unit_test_zh.md
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unittest/workload/xdp_test.c | Removed expired unit test implementation |
| test/unittest/workload/run_tests.sh | Removed outdated test runner script |
| test/unittest/workload/common.h | Removed unused header definitions and test macros |
| test/unittest/workload/Makefile | Removed obsolete build instructions for unit tests |
| docs/ebpf_unit_test_zh.md | Added documentation outlining the new testing framework |
Comments suppressed due to low confidence (2)
docs/ebpf_unit_test_zh.md:1
- Consider including explicit instructions on how to run the new eBPF unit tests (e.g., command examples or integration details with the CI pipeline) to help users transition from the removed Makefile-based approach.
# Kmesh eBPF 单元测试框架文档
test/unittest/workload/xdp_test.c:1
- Since the expired test files are being removed, please ensure that any necessary tests have been migrated to the new framework to avoid any gaps in test coverage.
#include <errno.h>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1209
Special notes for your reviewer:
Does this PR introduce a user-facing change?: