Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies. #263

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Update dependencies. #263

merged 1 commit into from
Sep 9, 2020

Conversation

JRBANCEL
Copy link
Contributor

@JRBANCEL JRBANCEL commented Sep 4, 2020

There are a lot of changes upstream breaking the repo.

The only thing I can't figure out is why some AutoTLS tests are seeing the wrong Gateway being created.
@ZhiminXiang do you have any clue?

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 4, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 4, 2020
@tcnghia
Copy link
Contributor

tcnghia commented Sep 5, 2020

/retest

I don't see any test legs running.

@nak3 nak3 mentioned this pull request Sep 6, 2020
Merged
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2020
@nak3 nak3 mentioned this pull request Sep 8, 2020
Closed
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-net-istio-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/ingress.go 81.8% 82.2% 0.4
pkg/reconciler/ingress/resources/virtual_service.go 95.3% 95.1% -0.2

@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Sep 9, 2020

@nak3 @ZhiminXiang @vagababov
This needs a /lgtm.

@ZhiminXiang
Copy link

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@knative-prow-robot knative-prow-robot merged commit 9fb6d8e into knative-extensions:master Sep 9, 2020
@JRBANCEL JRBANCEL mentioned this pull request Sep 21, 2020
Closed
This was referenced Feb 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JRBANCEL @knative-prow-robot @tcnghia @knative-metrics-robot @ZhiminXiang @googlebot