Prober targets service instead of pods directly

[pierDipi]

Istio doesn't work well when there is pod to pod communication.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Fixes #2107

Proposed Changes

• Prober targets service instead of pods directly

Release Note

Receiver's prober targets services instead of pods directly to allow components to be part of an Istio mesh

[codecov]

Codecov Report

Merging #2112 (93b3108) into main (b2c0499) will increase coverage by 0.04%.
The diff coverage is 95.23%.

@@             Coverage Diff              @@
##               main    #2112      +/-   ##
============================================
+ Coverage     66.55%   66.60%   +0.04%     
- Complexity      676      677       +1     
============================================
  Files           142      142              
  Lines          9138     9147       +9     
  Branches        196      196              
============================================
+ Hits           6082     6092      +10     
+ Misses         2651     2650       -1     
  Partials        405      405              

Flag	Coverage Δ
java-unittests	82.58% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
control-plane/pkg/prober/async_prober.go	88.88% <88.88%> (+0.13%)	⬆️
control-plane/pkg/prober/prober.go	67.74% <100.00%> (+4.77%)	⬆️
control-plane/pkg/reconciler/broker/controller.go	82.55% <100.00%> (+0.20%)	⬆️
control-plane/pkg/reconciler/channel/controller.go	89.02% <100.00%> (+0.13%)	⬆️
...ol-plane/pkg/reconciler/channel/v2/controllerv2.go	100.00% <100.00%> (ø)
control-plane/pkg/reconciler/sink/controller.go	77.94% <100.00%> (+0.32%)	⬆️
...a/broker/dispatcher/impl/RecordDispatcherImpl.java	89.88% <0.00%> (-0.57%)	⬇️
...ispatcher/impl/http/WebClientCloudEventSender.java	62.79% <0.00%> (+2.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c0499...93b3108. Read the comment docs.

[pierDipi]

[ERROR] Plugin org.apache.maven.plugins:maven-shade-plugin:3.3.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-shade-plugin:jar:3.3.0: Could not transfer artifact org.apache.maven.plugins:maven-shade-plugin:pom:3.3.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-shade-plugin/3.3.0/maven-shade-plugin-3.3.0.pom: Connection reset -> [Help 1]

/test unit-tests_eventing-kafka-broker_main

[matzew]

LGTM

but, I'd like to see some feedback on if the patch worked in your environment, @LeonardAukea

[LeonardAukea]

@markhulia how is it going with the tests?

[pierDipi]

The patch worked #2107 (comment)

/cherry-pick release-v1.4

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.4 in a new PR and assign it to you.

In response to this:

The patch worked #2107 (comment)

/cherry-pick release-v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/cherry-pick release-1.4

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/cherry-pick release-1.3

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/cc @matzew

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@pierDipi: new pull request created: #2158

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@pierDipi: new pull request created: #2159

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@pierDipi: cannot checkout release-v1.4: error checking out release-v1.4: exit status 1. output: error: pathspec 'release-v1.4' did not match any file(s) known to git

In response to this:

The patch worked #2107 (comment)

/cherry-pick release-v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/cherry-pick release-1.2

[knative-prow-robot]

@pierDipi: #2112 failed to apply on top of branch "release-1.2":

Applying: Prober targets service instead of pods directly
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/broker/controller.go
M	control-plane/pkg/reconciler/channel/controller.go
A	control-plane/pkg/reconciler/channel/v2/controllerv2.go
M	data-plane/config/broker/500-receiver.yaml
M	data-plane/config/channel/500-receiver.yaml
M	data-plane/config/sink/500-receiver.yaml
Falling back to patching base and 3-way merge...
Auto-merging data-plane/config/sink/500-receiver.yaml
Auto-merging data-plane/config/channel/500-receiver.yaml
Auto-merging data-plane/config/broker/500-receiver.yaml
CONFLICT (modify/delete): control-plane/pkg/reconciler/channel/v2/controllerv2.go deleted in HEAD and modified in Prober targets service instead of pods directly. Version Prober targets service instead of pods directly of control-plane/pkg/reconciler/channel/v2/controllerv2.go left in tree.
Auto-merging control-plane/pkg/reconciler/channel/controller.go
Auto-merging control-plane/pkg/reconciler/broker/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Prober targets service instead of pods directly
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aliok]

Manual cherry pick into 1.2 branch: #2180