Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate CRDs, like we have on eventing core #799

Merged
merged 1 commit into from Aug 9, 2021
Merged

Separate CRDs, like we have on eventing core #799

merged 1 commit into from Aug 9, 2021

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Aug 9, 2021 •
edited

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

as per title

Proposed Changes

  • separation of CRDs, like on eventing

Release Note

Separated CRDs to extra, additional yaml manifest (similar to eventing)

Docs

@matzew
Separate CRDs, like we have on eventing core
32b2592 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2021
@devguyio devguyio self-assigned this Aug 9, 2021
aliok
aliok reviewed Aug 9, 2021
View reviewed changes
hack/release.sh
@@ -26,8 +26,10 @@ declare -A COMPONENTS
COMPONENTS=(
["channel-consolidated.yaml"]="config/channel/consolidated"
["channel-distributed.yaml"]="config/channel/distributed"
["channel-crds.yaml"]="config/channel/resources"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which file the CRDs are currently at?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is defined in here: https://github.com/knative-sandbox/eventing-kafka/blob/main/config/channel/resources/kafkachannel-crd.yaml

And like on "eventing", we will have an extra file for just the CRDs. See here as reference:
https://github.com/knative/eventing/blob/main/hack/generate-yamls.sh#L91-L94

This PR allows better reuse of just the CRDs

@devguyio
Copy link
Contributor

devguyio commented Aug 9, 2021

I don't know how the current release script works exactly but I'm fine with this change. Maybe it's a good idea to add a release note saying that the CRDs are now part of the release artifacts?

/lgtm
/hold

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #799 (32b2592) into main (09a48db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   75.47%   75.47%           
=======================================
  Files         144      144           
  Lines        6513     6513           
=======================================
  Hits         4916     4916           
  Misses       1376     1376           
  Partials      221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a48db...32b2592. Read the comment docs.

@matzew
Copy link
Contributor Author

matzew commented Aug 9, 2021

release notes added!

@matzew
Copy link
Contributor Author

matzew commented Aug 9, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021
@knative-prow-robot knative-prow-robot merged commit ca074b4 into knative-extensions:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok left review comments

Assignees

@devguyio devguyio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matzew @knative-prow-robot @devguyio @aliok