Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secrets inheritance in unit test workflow #213

Merged
merged 1 commit into from
May 15, 2024

Conversation

dsimansk
Copy link
Contributor

  • Allow secrets inheritance in unit test workflow

@upodroid @cardil PTAL

A follow-up to my previous PR #211 per docs:
https://docs.github.com/en/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow

@knative-prow knative-prow bot requested review from cardil and upodroid May 14, 2024 12:28
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

knative-prow bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e25849d into knative:main May 15, 2024
7 checks passed
@dsimansk dsimansk deleted the pr/codecov-token branch May 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants