Add BuildTemplate for makisu #90
Conversation
|
Hi @johscheuer. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| (_required_) | ||
| * **CONTEXTPATH**: The path to the build context (_default:_ | ||
| `/workspace`) | ||
| * **PUSH_REGISTRY**: The Registry to push the image to (_default:_ |
There was a problem hiding this comment.
How does this work if IMAGE is not a Dockerhub image? Is it just unused?
There was a problem hiding this comment.
There was a problem hiding this comment.
You need to create a secret for the registry like in the docker example and then reference it with PUSH_REGISTRY, makisu also supports to push to multiple registries (which is currently not implemented in this PR.
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, johscheuer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a simple BuildTemplate for makisu (https://github.com/uber/makisu). As soon as knative/build#550 gets merged I would adjust the Secret Volume to be rendered by a Template Parameter rather than a hardcoded string.
Currently the makisu setup doesn't use a global build cache (mentioned here: https://github.com/uber/makisu#using-cache) if you want I can add an example for the global cache too.
Fixes: #77