Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more details in the output of service list command #40

Closed
navidshaikh opened this issue Mar 13, 2019 · 4 comments · Fixed by #90
Closed

Add more details in the output of service list command #40

navidshaikh opened this issue Mar 13, 2019 · 4 comments · Fixed by #90
Milestone
v0.1.0

Comments

@navidshaikh
Copy link
Collaborator

navidshaikh commented Mar 13, 2019 •
edited
Loading

kn service list lists only the names of services. It could add new columns in the output to print
additional information about the service.
@csantanapr
Copy link
Member

/milestone v0.1.0

@knative-prow-robot
Copy link
Contributor

@csantanapr: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v0.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@navidshaikh
Copy link
Collaborator Author 

./kn service list
NAME            DOMAIN                              LATESTCREATED         LATESTREADY
helloservice    helloservice.default.example.com    helloservice-vs6bm    helloservice-vs6bm

does this set of columns look okay ? Do we want to add more there ?

navidshaikh added a commit to navidshaikh/client that referenced this issue Apr 4, 2019
@navidshaikh
Adds more columns in service list command output
6c67823 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
@navidshaikh navidshaikh mentioned this issue Apr 4, 2019
Closed
@navidshaikh
Copy link
Collaborator Author

Added another column in the output of service list output

./kn service list
NAME            DOMAIN                              LATESTCREATED         LATESTREADY           AGE
helloservice    helloservice.default.example.com    helloservice-vs6bm    helloservice-vs6bm    1d

@csantanapr csantanapr added this to the v0.1.0 milestone Apr 5, 2019
navidshaikh added a commit to navidshaikh/client that referenced this issue Apr 9, 2019
@navidshaikh
Adds more columns in service list command output
1d6e1b0 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
navidshaikh added a commit to navidshaikh/client that referenced this issue Apr 10, 2019
@navidshaikh
Adds more columns in service list command output
9724489 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
navidshaikh added a commit to navidshaikh/client that referenced this issue Apr 12, 2019
@navidshaikh
Adds more columns in service list command output
3a5c43a 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
navidshaikh added a commit to navidshaikh/client that referenced this issue Apr 24, 2019
@navidshaikh
Adds more columns in service list command output
10da49f 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
navidshaikh added a commit to navidshaikh/client that referenced this issue May 1, 2019
@navidshaikh
Adds more columns in service list command output
294a884 
 This commit adds basic details about service in
 service list command output.
 text/tabwriter is used to print columns on stdout.

 Fixes #knative#40
@navidshaikh navidshaikh mentioned this issue May 3, 2019
Merged
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Use default GKE version for test cluster (knative#63)
2f17ed7 
`gke-latest` points to head, and these images might not yet be available for platforms other than Linux (e.g., Mac).

Fixes knative#40.
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
The current approach for running the E2E tests through kubetest is …
7cb4d66 
…to let the tool magically download kubernetes and start the cluster. (knative#86)

To ensure that our tests don't unexpectedly break, we don't pin the kubernetes version to a particular one (knative/serving#1294) but always use `latest`.

However, the concept of `latest` for kubetests means "kubernetes head", which can be broken (didn't happen so far) or doesn't support all platforms (OS X is the most common case).

Unfortunately, switching to `default` or `release/stable` translates to kubernetes 1.9, which is not recommended for Knative according to the docs.

This PR adds the function `download_k8s()`: it will download the latest public, stable GKE binary supported by the test cluster and the client machine.

As a bonus, the function knocks out the `kubernetes-test.tar.gz` package; this 1.2GB package is not used by Knative tests, and is a severe burden on slower connections (anedoctal evidence: 20+ min download on my home network).

Fixes knative#40.

Bonus: fixes knative#80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Adds service get command navidshaikh/client
3 participants
@csantanapr @navidshaikh @knative-prow-robot