From 85acde8147c1e285d19fbf809dfc2ca05ee4e3cc Mon Sep 17 00:00:00 2001 From: Mike Helmick Date: Sun, 23 Jun 2019 14:14:52 -0700 Subject: [PATCH] Update documentation for httpsRedirect to include the redirect in the http section and not the https section. --- docs/serving/using-cert-manager-on-gcp.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/serving/using-cert-manager-on-gcp.md b/docs/serving/using-cert-manager-on-gcp.md index 4ef1c49dcd5..29501e8610e 100644 --- a/docs/serving/using-cert-manager-on-gcp.md +++ b/docs/serving/using-cert-manager-on-gcp.md @@ -259,6 +259,10 @@ spec: protocol: HTTP hosts: - "*" + tls: + # Sends 301 redirect for all http requests. + # Omit to allow http and https. + httpsRedirect: true - port: number: 443 name: https @@ -266,7 +270,6 @@ spec: hosts: - "*" tls: - httpsRedirect: true # sends 301 redirect for http requests. mode: SIMPLE privateKey: /etc/istio/ingressgateway-certs/tls.key serverCertificate: /etc/istio/ingressgateway-certs/tls.crt