From 75165942f89be05e71aff4057b61c3b381dcd12d Mon Sep 17 00:00:00 2001 From: Powell Quiring Date: Sun, 18 Aug 2019 08:37:51 -0700 Subject: [PATCH 1/4] typo --- docs/serving/knative-kubernetes-services.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/serving/knative-kubernetes-services.md b/docs/serving/knative-kubernetes-services.md index e24e54f7c96..d4418da340e 100644 --- a/docs/serving/knative-kubernetes-services.md +++ b/docs/serving/knative-kubernetes-services.md @@ -31,7 +31,6 @@ that are active when running Knative Serving. webhook ClusterIP 10.107.144.50 443/TCP 1h ``` -```` 3. To view the deployments in your cluster, use the following command: ```sh @@ -41,6 +40,7 @@ that are active when running Knative Serving. This should return the following output: ```sh +``` NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE activator 1 1 1 1 1h autoscaler 1 1 1 1 1h @@ -48,7 +48,7 @@ controller 1 1 1 1 1h networking-certmanager 1 1 1 1 1h networking-istio 1 1 1 1 1h webhook 1 1 1 1 1h -```` +``` These services and deployments are installed by the `serving.yaml` file during install. The next section describes their function. From 58e5592c42f1c03cc95cee090d0bb9d64aadb691 Mon Sep 17 00:00:00 2001 From: Powell Quiring Date: Sun, 25 Aug 2019 09:10:35 -0700 Subject: [PATCH 2/4] directory confusion missing readinessProbe config readinessProbe requires timeoutSeconds and failureThreshold are required close #1731 --- docs/serving/samples/rest-api-go/README.md | 8 ++------ docs/serving/samples/rest-api-go/sample-template.yaml | 2 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/serving/samples/rest-api-go/README.md b/docs/serving/samples/rest-api-go/README.md index ea54bd3298d..9bb7541fc62 100644 --- a/docs/serving/samples/rest-api-go/README.md +++ b/docs/serving/samples/rest-api-go/README.md @@ -25,7 +25,7 @@ like `AAPL`,`AMZN`, `GOOG`, `MSFT`, etc. ```shell git clone -b "{{< branch >}}" https://github.com/knative/docs knative-docs - cd knative-docs/serving/samples/rest-api-go + cd knative-docs ``` ## Setup @@ -37,11 +37,7 @@ This sample uses Docker for both building and pushing. To build and push to a container registry using Docker: -1. Move into the sample directory: - - ```shell - cd $GOPATH/src/github.com/knative/docs - ``` +1. Continue in the knative-docs directory previously cloned 2. Set your preferred container registry endpoint as an environment variable. This sample uses diff --git a/docs/serving/samples/rest-api-go/sample-template.yaml b/docs/serving/samples/rest-api-go/sample-template.yaml index 17b2f804c6a..395cc5235b9 100644 --- a/docs/serving/samples/rest-api-go/sample-template.yaml +++ b/docs/serving/samples/rest-api-go/sample-template.yaml @@ -29,3 +29,5 @@ spec: path: / initialDelaySeconds: 0 periodSeconds: 3 + timeoutSeconds: 11 + failureThreshold: 3 From 4b98472ec112f197b1d497d5c37b732eefdb20a7 Mon Sep 17 00:00:00 2001 From: RichieEscarez Date: Tue, 3 Sep 2019 15:10:38 -0700 Subject: [PATCH 3/4] fix indentation and remove duplicate codeblock --- docs/serving/knative-kubernetes-services.md | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/serving/knative-kubernetes-services.md b/docs/serving/knative-kubernetes-services.md index d4418da340e..f981763b00b 100644 --- a/docs/serving/knative-kubernetes-services.md +++ b/docs/serving/knative-kubernetes-services.md @@ -40,15 +40,14 @@ that are active when running Knative Serving. This should return the following output: ```sh -``` -NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE -activator 1 1 1 1 1h -autoscaler 1 1 1 1 1h -controller 1 1 1 1 1h -networking-certmanager 1 1 1 1 1h -networking-istio 1 1 1 1 1h -webhook 1 1 1 1 1h -``` + NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE + activator 1 1 1 1 1h + autoscaler 1 1 1 1 1h + controller 1 1 1 1 1h + networking-certmanager 1 1 1 1 1h + networking-istio 1 1 1 1 1h + webhook 1 1 1 1 1h + ``` These services and deployments are installed by the `serving.yaml` file during install. The next section describes their function. From 4beb6330064ac9d2643e89f7f7ec902d7dcda4cc Mon Sep 17 00:00:00 2001 From: RichieEscarez Date: Tue, 3 Sep 2019 15:13:10 -0700 Subject: [PATCH 4/4] Consolidate 1 and 2 --- docs/serving/samples/rest-api-go/README.md | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/serving/samples/rest-api-go/README.md b/docs/serving/samples/rest-api-go/README.md index 9bb7541fc62..50c30bda969 100644 --- a/docs/serving/samples/rest-api-go/README.md +++ b/docs/serving/samples/rest-api-go/README.md @@ -37,18 +37,17 @@ This sample uses Docker for both building and pushing. To build and push to a container registry using Docker: -1. Continue in the knative-docs directory previously cloned - -2. Set your preferred container registry endpoint as an environment variable. +1. From the `knative-docs` directory, run the following command to set your + container registry endpoint as an environment variable. + This sample uses [Google Container Registry (GCR)](https://cloud.google.com/container-registry/): - - + ```shell export REPO="gcr.io/" ``` -3. Set up your container registry to make sure you are ready to push. +1. Set up your container registry to make sure you are ready to push. To push to GCR, you need to: @@ -63,7 +62,7 @@ To build and push to a container registry using Docker: If you are using a different container registry, you will want to follow the registry specific instructions for both setup and authorizing the image push. -4. Use Docker to build your application container: +1. Use Docker to build your application container: ```shell docker build \ @@ -71,13 +70,13 @@ To build and push to a container registry using Docker: --file docs/serving/samples/rest-api-go/Dockerfile . ``` -5. Push your container to a container registry: +1. Push your container to a container registry: ```shell docker push "${REPO}/rest-api-go" ``` -6. Substitute the image reference path in the template with our published image +1. Substitute the image reference path in the template with our published image path. The command below substitutes using the \${REPO} variable into a new file called `docs/serving/samples/rest-api-go/sample.yaml`.