Skip to content

Create Knative-with-MicroK8s.md #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2019
Merged

Create Knative-with-MicroK8s.md #1747

merged 6 commits into from
Sep 17, 2019

Conversation

@ammarn911
Copy link
Contributor

@ammarn911 ammarn911 commented Aug 28, 2019

Proposed Changes

  • Adding Knative on MicroK8s to the docs.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 28, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 28, 2019

Hi @ammarn911. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2019
@ammarn911
Copy link
Contributor Author

ammarn911 commented Aug 28, 2019

/assign @samodell

@ammarn911
Copy link
Contributor Author

ammarn911 commented Sep 3, 2019

can this get an ok-to-test please?

sebgoa
sebgoa reviewed Sep 5, 2019
View reviewed changes
sebgoa
sebgoa reviewed Sep 5, 2019
View reviewed changes
docs/install/Knative-with-MicroK8s.md

```shell
echo 'N;' | microk8s.enable knative
```
Copy link
Contributor

@sebgoa sebgoa Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description of what gets installed and which version. This feels a bit too magical with little information

Copy link

@dgerd dgerd Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 It would be great to know what version gets installed and how this will be kept up-to-date.

Copy link
Contributor

@samodell samodell Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammarn911 Can you explicitly list what gets installed with this command? With that change, I'll be able to approve and LGTM this so it merges.

Copy link
Contributor Author

@ammarn911 ammarn911 Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samodell done. Added what gets installed; Knative Serving v0.7.1 and Knative Eventing v0.7.1

Copy link
Contributor

@abrennan89 abrennan89 Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammarn911 do you know if these versions are updated and reflect the current versions?
I am working on #1850 so I was wondering if you can confirm whether we can remove mention of the versions or not.
Thanks! 🙂

dgerd
dgerd reviewed Sep 5, 2019
View reviewed changes
Copy link

@dgerd dgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

docs/install/Knative-with-MicroK8s.md

```shell
echo 'N;' | microk8s.enable knative
```
Copy link

@dgerd dgerd Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 It would be great to know what version gets installed and how this will be kept up-to-date.

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2019
@ammarn911
Knative-with-MicroK8s.md Doc edits
f546313 
Addressing suggestions.
@ammarn911
Updating Knative-with-MicroK8s.md
e708d76 
Addressing suggestions.
ammarn911
ammarn911 commented Sep 9, 2019
View reviewed changes
Copy link
Contributor Author

@ammarn911 ammarn911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback @sebgoa and @dgerd !

Added details and the Knative version to the PR. Also updated cleanup command.

dgerd
dgerd reviewed Sep 9, 2019
View reviewed changes
@ammarn911
Updating Knative-with-MicroK8s.md
c783a14 
Better version info and delete command
dgerd
dgerd reviewed Sep 9, 2019
View reviewed changes
@ammarn911
Updating Knative-with-MicroK8s.md
df5506b 
Adding lines of communication for support/contributing.
@dgerd
Copy link

dgerd commented Sep 9, 2019

/lgtm

/assign @samodell

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
RichieEscarez
RichieEscarez reviewed Sep 17, 2019
View reviewed changes
@ammarn911
Update Knative-with-MicroK8s.md
1092b87 
Addressing suggestions.
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@samodell
Copy link
Contributor

samodell commented Sep 17, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammarn911, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4270b17 into knative:master Sep 17, 2019
@abrennan89 abrennan89 mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samodell samodell Awaiting requested review from samodell

4 more reviewers

@sebgoa sebgoa sebgoa left review comments

@RichieEscarez RichieEscarez RichieEscarez left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@dgerd dgerd dgerd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@samodell samodell

@dgerd dgerd

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ammarn911 @knative-prow-robot @dgerd @samodell @sebgoa @RichieEscarez @abrennan89 @googlebot