Skip to content

Conversation

@RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Sep 19, 2019

The API build tool is now broken for both Serving and Eventing for 0.9 (details).

Only knative/eventing-contrib builds clean. For Serving and Eventing, those files now temporarily point to the API folders of knative/serving and knative/eventing.
Example:
"See the Knative Serving repo for the API.
There is currently an API doc build tool issue that we hope to resolve soon.""

This PR also updates the README and script so that they use intuitive file names (map to repo names).

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 19, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1397e22 into knative:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants