Skip to content

Conversation

@abrennan89
Copy link
Contributor

Fixes #2114

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 27, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2020
@abrennan89 abrennan89 requested review from carieshmarie, mattmoor, n3wscott and rhuss and removed request for houshengbo and markusthoemmes February 27, 2020 16:58
@abrennan89 abrennan89 added this to the 0.13.x milestone Feb 27, 2020
@mattmoor
Copy link
Member

/approve

Will leave LGTM to @rhuss

Copy link
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, mattmoor, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abrennan89 abrennan89 added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@knative-prow-robot knative-prow-robot merged commit f2b8e98 into knative:master Feb 28, 2020
@abrennan89 abrennan89 deleted the 2045 branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow up -- review fixes for PR 2045

6 participants