Skip to content

Rename Monitoring bundle to Observability plugin. #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

Rename Monitoring bundle to Observability plugin. #2269

merged 2 commits into from
Mar 4, 2020

Conversation

@mattmoor
Copy link
Member

@mattmoor mattmoor commented Mar 4, 2020

Related: #2265

/assign @ellenevans @RichieEscarez

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 4, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Mar 4, 2020

awesome, thanks Matt!

one question, does this content align with the existing instructions here: https://knative.dev/development/serving/installing-logging-metrics-traces/

do we cross link them?

@mattmoor
Copy link
Member Author

mattmoor commented Mar 4, 2020

I haven't touched that, and if it worked before it should still work.

@mattmoor
Copy link
Member Author

mattmoor commented Mar 4, 2020

The link check is non-blocking and upset by a link with a hugo shortcode embedded :(

@RichieEscarez RichieEscarez added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
@mattmoor mattmoor force-pushed the monitoring-to-observability branch from 978a5f1 to de1043c Compare March 4, 2020 01:27
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 4, 2020

New changes are detected. LGTM label has been removed.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
RichieEscarez
RichieEscarez suggested changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few minutes on the bus to quick review this and have some suggestions

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
mattmoor
mattmoor commented Mar 4, 2020
View reviewed changes
Copy link
Member Author

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFAL

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 4, 2020

@mattmoor: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check 86b9111 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RichieEscarez RichieEscarez added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@knative-prow-robot knative-prow-robot merged commit 04d13ef into knative:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@k4leung4 k4leung4 Awaiting requested review from k4leung4

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

@ellenevans ellenevans

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattmoor @knative-prow-robot @RichieEscarez @googlebot @ellenevans