From dfbac9660f8475149bd7da61a58709796fcc2c1a Mon Sep 17 00:00:00 2001 From: Pierangelo Di Pilato Date: Tue, 18 Aug 2020 18:03:45 +0200 Subject: [PATCH 1/2] Document all event delivery parameters Signed-off-by: Pierangelo Di Pilato --- docs/eventing/event-delivery.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/eventing/event-delivery.md b/docs/eventing/event-delivery.md index 4a689cc722a..5f2bf003aff 100644 --- a/docs/eventing/event-delivery.md +++ b/docs/eventing/event-delivery.md @@ -39,6 +39,8 @@ The `deadLetterSink` specifies where to send events that failed be consumed by ` ## Common Delivery Parameters +The `delivery` value must be a [Delivery Spec](https://pkg.go.dev/knative.dev/eventing/pkg/apis/duck/v1?tab=doc#DeliverySpec) + ### deadLetterSink When present, events that failed to be consumed are sent to the `deadLetterSink`. @@ -50,6 +52,9 @@ The `deadLetterSink` value must be a [Destination](https://pkg.go.dev/knative.de spec: delivery: deadLetterSink: + retry: + backoffPolicy: + backoffDelay: ``` ## Channel Support @@ -58,7 +63,7 @@ The table below summarizes what delivery parameters are supported for each chann | Channel Type | Supported Delivery Parameters | | - | - | -| In-Memory | `deadLetterSink` | -| Kafka | none | +| In-Memory | `deadLetterSink`, `retry`, `backoffPolicy`, `backoffDelay` | +| Kafka | `deadLetterSink`, `retry`, `backoffPolicy`, `backoffDelay` | | Natss | none | | GCP PubSub | none | From 9d6585a183a3e19c59112e1531769fa74a7083c7 Mon Sep 17 00:00:00 2001 From: Pierangelo Di Pilato Date: Tue, 18 Aug 2020 18:19:30 +0200 Subject: [PATCH 2/2] Fix typo: linerar -> linear Signed-off-by: Pierangelo Di Pilato --- docs/eventing/event-delivery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/eventing/event-delivery.md b/docs/eventing/event-delivery.md index 5f2bf003aff..a461c5e6c8f 100644 --- a/docs/eventing/event-delivery.md +++ b/docs/eventing/event-delivery.md @@ -53,7 +53,7 @@ spec: delivery: deadLetterSink: retry: - backoffPolicy: + backoffPolicy: backoffDelay: ```