[release-0.18] Fix default installation without sidecar injection (#2775) #2885
Conversation
|
@nak3: GitHub didn't allow me to request PR reviews from the following users: guillaumeblaquiere. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
knative-prow-robot
added
the
size/XS
* Fix default installation without sidecar injection manifest apply no longer exists in istioctl CLI. Add runAsRoot to allow targetPort creation bellow 1024. * Remove the asRoot Use targetPort instead of asRoot CLI parameter * Remove manifest to istioctl
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
|
Could you please take a look? @ZhiminXiang @JRBANCEL @tcnghia |
|
/lgtm |
|
/lgtm |
|
@mpetason @abrennan89 @tcnghia |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, tcnghia, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
This is a cherry-pick for bd6307f against release-0.18 branch.
/cc @ZhiminXiang @JRBANCEL @guillaumeblaquiere