Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding COC doc #4285

Merged
merged 2 commits into from Sep 24, 2021
Merged

Adding COC doc #4285

merged 2 commits into from Sep 24, 2021

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Sep 24, 2021 •
edited

Changes

/assign @omerbensaadon @snneji

@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 9df1535

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/614dd64f1577690008aa1414

😎 Browse the preview: https://deploy-preview-4285--knative.netlify.app

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 24, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2021
@psschwei psschwei mentioned this pull request Sep 24, 2021
Closed
10 tasks
@omerbensaadon
Copy link

thank you @psschwei!

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerbensaadon, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@omerbensaadon
Copy link

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@omerbensaadon
Copy link

/unhold
/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 24, 2021
@knative-prow-robot knative-prow-robot merged commit 451bbfd into knative:main Sep 24, 2021
@psschwei psschwei deleted the ga-docs branch November 4, 2021 15:06
@csantanapr csantanapr mentioned this pull request Dec 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@omerbensaadon omerbensaadon

@snneji snneji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@psschwei @omerbensaadon @knative-prow-robot @snneji