Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go redirect #5531

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix go redirect #5531

merged 2 commits into from
Apr 13, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Apr 12, 2023

we've been getting 404s with netlify with the go get redirect.

I opened an netlify support issue and they suggested that the cause might be because the _redirect format isn't valid (go-get=1)

Part of #5532

@knative-prow knative-prow bot requested review from nainaz and psschwei April 12, 2023 01:36
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2023
@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for knative ready!

Name Link
🔨 Latest commit def2338
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64360b18ea52de0008371e23
😎 Deploy Preview https://deploy-preview-5531--knative.netlify.app/golang/func-go
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dprotaso
Copy link
Member Author

Going to close this - netlify support said

We detected a small bug on the way we handled these requests within the same CDN node. Mind trying to hit the 404's are still seen?

@dprotaso dprotaso closed this Apr 12, 2023
@dprotaso dprotaso reopened this Apr 12, 2023
@dprotaso
Copy link
Member Author

Actually we should still do some cleanup

/client/* go-get=:go-get /golang/client.html 200
/client-pkg/* go-get=:go-get /golang/client-pkg.html 200
/community/* go-get=:go-get /golang/community.html 200
/container-freezer/* go-get=:go-get /golang/container-freezer.html 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete this one since we're archiving the repo whenever I remember to actually do it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you archive the repo - we can regenerate this config that will remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tool (tools/redir-gen) ignores archived repos

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 48ed3a4 into knative:main Apr 13, 2023
@dprotaso dprotaso deleted the fix-redirect branch April 13, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants