-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix go redirect #5531
fix go redirect #5531
Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Going to close this - netlify support said
|
Actually we should still do some cleanup |
/client/* go-get=:go-get /golang/client.html 200 | ||
/client-pkg/* go-get=:go-get /golang/client-pkg.html 200 | ||
/community/* go-get=:go-get /golang/community.html 200 | ||
/container-freezer/* go-get=:go-get /golang/container-freezer.html 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we delete this one since we're archiving the repo whenever I remember to actually do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you archive the repo - we can regenerate this config that will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tool (tools/redir-gen
) ignores archived repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
we've been getting 404s with netlify with the go get redirect.
I opened an netlify support issue and they suggested that the cause might be because the
_redirect
format isn't valid (go-get=1
)Part of #5532