From 38a237562b44e47511191aebc29cea031f3ef611 Mon Sep 17 00:00:00 2001 From: Doug Davis Date: Tue, 8 Jan 2019 07:19:09 -0800 Subject: [PATCH 1/2] Tweaks docs to create Istio CRDs first Closes #540 If people are ok with this change I'll make similar modifications to the other instruction files too. Signed-off-by: Doug Davis --- install/Knative-with-IKS.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/install/Knative-with-IKS.md b/install/Knative-with-IKS.md index ddc0bd4673a..bbf3f64d31d 100644 --- a/install/Knative-with-IKS.md +++ b/install/Knative-with-IKS.md @@ -137,8 +137,18 @@ Knative depends on Istio. 1. Install Istio: ```bash + kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \ kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml ``` + Note: the resources (CRDs) defined in `istio-crds.yaml` are technically + also included in the `istio.yaml` file. They are pulled out and processed + separately because sometimes when they are created as part of the same + yaml file as the rest of the Istio resources, the CRD definitions + themselves are not created quickly enough and then resources of those types + fail to be created with an error complaining about an unknown type. + If for some reason you still see this type of error try rerunning the + second `kubectl apply` command again and then it should work. + 1. Label the default namespace with `istio-injection=enabled`: ```bash kubectl label namespace default istio-injection=enabled From 0363771f867df807b4eb50e6bf9b3999dd1b0f40 Mon Sep 17 00:00:00 2001 From: Caroline Lee Date: Tue, 8 Jan 2019 16:26:53 -0800 Subject: [PATCH 2/2] Update Knative-with-IKS.md --- install/Knative-with-IKS.md | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/install/Knative-with-IKS.md b/install/Knative-with-IKS.md index bbf3f64d31d..8c645792f27 100644 --- a/install/Knative-with-IKS.md +++ b/install/Knative-with-IKS.md @@ -140,14 +140,11 @@ Knative depends on Istio. kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \ kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml ``` - Note: the resources (CRDs) defined in `istio-crds.yaml` are technically - also included in the `istio.yaml` file. They are pulled out and processed - separately because sometimes when they are created as part of the same - yaml file as the rest of the Istio resources, the CRD definitions - themselves are not created quickly enough and then resources of those types - fail to be created with an error complaining about an unknown type. - If for some reason you still see this type of error try rerunning the - second `kubectl apply` command again and then it should work. + Note: the resources (CRDs) defined in the `istio-crds.yaml`file are + also included in the `istio.yaml` file, but they are pulled out so that + the CRD definitions are created first. If you see an error when creating + resources about an unknown type, run the second `kubectl apply` command + again. 1. Label the default namespace with `istio-injection=enabled`: ```bash