From fc9a4861866c0acd93d326c97eef3c79e0c7d6a1 Mon Sep 17 00:00:00 2001 From: Steren Date: Thu, 10 Jan 2019 15:26:32 -0800 Subject: [PATCH 1/5] Add link to image in Dockerhub Mainly for consistency with other samples. --- serving/samples/helloworld-go/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/serving/samples/helloworld-go/Dockerfile b/serving/samples/helloworld-go/Dockerfile index 7ded7358346..cc8b481c3e4 100644 --- a/serving/samples/helloworld-go/Dockerfile +++ b/serving/samples/helloworld-go/Dockerfile @@ -1,5 +1,6 @@ # Use the offical Golang image to create a build artifact. # This is based on Debian and sets the GOPATH to /go. +# https://hub.docker.com/_/golang FROM golang as builder # Copy local code to the container image. From ca9f76b612b460924ae2c893e58a7e713a592af5 Mon Sep 17 00:00:00 2001 From: Steren Date: Thu, 10 Jan 2019 15:27:18 -0800 Subject: [PATCH 2/5] also README --- serving/samples/helloworld-go/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/serving/samples/helloworld-go/README.md b/serving/samples/helloworld-go/README.md index 744e591b490..54a807b7454 100644 --- a/serving/samples/helloworld-go/README.md +++ b/serving/samples/helloworld-go/README.md @@ -61,6 +61,7 @@ recreate the source files from this folder. ```docker # Use the offical Golang image to create a build artifact. # This is based on Debian and sets the GOPATH to /go. + # https://hub.docker.com/_/golang FROM golang as builder # Copy local code to the container image. From 4e546c9de29b5dadb4d16b10b737a205332e7717 Mon Sep 17 00:00:00 2001 From: Sam O'Dell <31352624+samodell@users.noreply.github.com> Date: Mon, 14 Jan 2019 09:08:58 -0800 Subject: [PATCH 3/5] Fixes indentation issue causing build test failure --- serving/samples/helloworld-go/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/serving/samples/helloworld-go/README.md b/serving/samples/helloworld-go/README.md index 54a807b7454..b9d0f0509ab 100644 --- a/serving/samples/helloworld-go/README.md +++ b/serving/samples/helloworld-go/README.md @@ -138,10 +138,10 @@ folder) you're ready to build and deploy the sample app. 1. Now that your service is created, Knative will perform the following steps: - - Create a new immutable revision for this version of the app. - - Network programming to create a route, ingress, service, and load balance - for your app. - - Automatically scale your pods up and down (including to zero active pods). + - Create a new immutable revision for this version of the app. + - Network programming to create a route, ingress, service, and load balance + for your app. + - Automatically scale your pods up and down (including to zero active pods). 1. Run the following command to find the external IP address for your service. The ingress IP for your cluster is returned. If you just created your From aa7c0cb61d10a3ced051cab170767adc83f00be4 Mon Sep 17 00:00:00 2001 From: Steren Date: Mon, 14 Jan 2019 09:14:21 -0800 Subject: [PATCH 4/5] fix bullet list indentation --- serving/samples/helloworld-go/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/serving/samples/helloworld-go/README.md b/serving/samples/helloworld-go/README.md index b9d0f0509ab..54a807b7454 100644 --- a/serving/samples/helloworld-go/README.md +++ b/serving/samples/helloworld-go/README.md @@ -138,10 +138,10 @@ folder) you're ready to build and deploy the sample app. 1. Now that your service is created, Knative will perform the following steps: - - Create a new immutable revision for this version of the app. - - Network programming to create a route, ingress, service, and load balance - for your app. - - Automatically scale your pods up and down (including to zero active pods). + - Create a new immutable revision for this version of the app. + - Network programming to create a route, ingress, service, and load balance + for your app. + - Automatically scale your pods up and down (including to zero active pods). 1. Run the following command to find the external IP address for your service. The ingress IP for your cluster is returned. If you just created your From ff4be63c81f6a0b533b56255a4952392d9407997 Mon Sep 17 00:00:00 2001 From: Sam O'Dell <31352624+samodell@users.noreply.github.com> Date: Mon, 14 Jan 2019 09:21:40 -0800 Subject: [PATCH 5/5] attempt #2 -- fixing build failure --- serving/samples/helloworld-go/README.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/serving/samples/helloworld-go/README.md b/serving/samples/helloworld-go/README.md index 54a807b7454..45211aa4a29 100644 --- a/serving/samples/helloworld-go/README.md +++ b/serving/samples/helloworld-go/README.md @@ -137,11 +137,10 @@ folder) you're ready to build and deploy the sample app. ``` 1. Now that your service is created, Knative will perform the following steps: - - - Create a new immutable revision for this version of the app. - - Network programming to create a route, ingress, service, and load balance - for your app. - - Automatically scale your pods up and down (including to zero active pods). + - Create a new immutable revision for this version of the app. + - Network programming to create a route, ingress, service, and load balance + for your app. + - Automatically scale your pods up and down (including to zero active pods). 1. Run the following command to find the external IP address for your service. The ingress IP for your cluster is returned. If you just created your