From b2413622d3fcf2b97d6cf67604278de180d07f2b Mon Sep 17 00:00:00 2001 From: "Johannes M. Scheuermann" Date: Sat, 26 Jan 2019 22:55:34 +0100 Subject: [PATCH 1/3] Correct spec documentation for GitHubSource --- eventing/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eventing/README.md b/eventing/README.md index 204edda7e7f..4de6d033145 100644 --- a/eventing/README.md +++ b/eventing/README.md @@ -158,7 +158,7 @@ The GitHubSource fires a new event for selected events from. The repository may be left off to receive events from an entire organization. - `eventTypes`: `[]string` A list of - [event types](https://developer.github.com/v3/activity/events/types/)in + [event types](https://developer.github.com/v3/activity/events/types/) in "Webhook event name" format (lower_case). - `accessToken.secretKeyRef`: [SecretKeySelector](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#secretkeyselector-v1-core) @@ -168,8 +168,8 @@ The GitHubSource fires a new event for selected [SecretKeySelector](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#secretkeyselector-v1-core) containing a GitHub secret token for configuring a GitHub webhook. One of this or `accessToken` must be set. -- `serviceAccountName`: `string` The name of the ServiceAccount used to access - the `gcpCredsSecret`. +- `serviceAccountName`: `string` The name of the ServiceAccount to run the + container as. - `sink`: [ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core) A reference to the object that should receive events. From 8179816d2182e9df889aab23bd242c6e6cc5e295 Mon Sep 17 00:00:00 2001 From: "Johannes M. Scheuermann" Date: Mon, 28 Jan 2019 18:45:46 +0100 Subject: [PATCH 2/3] Use wording suggestion --- eventing/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eventing/README.md b/eventing/README.md index 4de6d033145..5ef5dcaa9ce 100644 --- a/eventing/README.md +++ b/eventing/README.md @@ -168,8 +168,8 @@ The GitHubSource fires a new event for selected [SecretKeySelector](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#secretkeyselector-v1-core) containing a GitHub secret token for configuring a GitHub webhook. One of this or `accessToken` must be set. -- `serviceAccountName`: `string` The name of the ServiceAccount to run the - container as. +- `serviceAccountName`: `string` The name of the ServiceAccount running as the + container. - `sink`: [ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core) A reference to the object that should receive events. From 6dbc54d0df92a645eb22b1966025f55c92e1e858 Mon Sep 17 00:00:00 2001 From: "Johannes M. Scheuermann" Date: Mon, 28 Jan 2019 22:56:47 +0100 Subject: [PATCH 3/3] Revert "Use wording suggestion" This reverts commit 8179816d2182e9df889aab23bd242c6e6cc5e295. --- eventing/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eventing/README.md b/eventing/README.md index 5ef5dcaa9ce..4de6d033145 100644 --- a/eventing/README.md +++ b/eventing/README.md @@ -168,8 +168,8 @@ The GitHubSource fires a new event for selected [SecretKeySelector](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#secretkeyselector-v1-core) containing a GitHub secret token for configuring a GitHub webhook. One of this or `accessToken` must be set. -- `serviceAccountName`: `string` The name of the ServiceAccount running as the - container. +- `serviceAccountName`: `string` The name of the ServiceAccount to run the + container as. - `sink`: [ObjectReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#objectreference-v1-core) A reference to the object that should receive events.