Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] default broker shall be removed when label `knative-eventing-injection` is removed #1504

Closed
daisy-ycguo opened this issue Jul 3, 2019 · 4 comments

Comments

@daisy-ycguo
Copy link
Member

commented Jul 3, 2019

Describe the bug
A default broker will be created when kubectl label namespace default knative-eventing-injection=enabled. Yet the default broker will not be deleted when removing the label by kubectl label namespace default knative-eventing-injection- or disabling the label by kubectl label namespace default knative-eventing-injection=disabled --overwrite

Expected behavior

  • There should be a way to delete default broker by manipulating the lable knative-eventing-injection, other than running kubectl delete broker default explicitly.
  • Document how to remove a default broker.

To Reproduce

  1. Create default broker by kubectl label namespace default knative-eventing-injection=enabled
  2. Check the default broker is there by kubectl get broker
  3. Remove the label by kubectl label namespace default knative-eventing-injection-
  4. Check the default broker is still there by kubectl get broker

Knative release version
0.6.0

Additional context
If it is by designed that deleting label will not delete default broker, I'm OK to close this issue but should document it.

@daisy-ycguo daisy-ycguo added the kind/bug label Jul 3, 2019

@daisy-ycguo daisy-ycguo changed the title [BUG] default broker shall be removed when lable `knative-eventing-injection` is removed [BUG] default broker shall be removed when label `knative-eventing-injection` is removed Jul 3, 2019

@vaikas-google

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@Harwayne

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

This is by design, but you are correct that we need to clearly document it. My guess is that this is the correct place to do so.

The reasoning is:

  • If you have the Broker injected and are using the Broker, do you expect the Broker to stop working when you remove the label?
    • When asked, people were about 50/50 on either it is expected to keep working or be deleted.
  • If you have the Broker injected and are using a different Broker in that namespace, do you expect all Brokers in the namespace to stop working when you remove the label?
    • Everyone said they did not expect or want this. To cleanup everything the injection does, it would cause all Brokers in the namespace to stop working.
@vaikas-google

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

@vaikas-google

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

oh, neat, magic happened automatically (linked the issues... YAY!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.