Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating channel delivery options diff logic needs work #4375

Closed
vaikas opened this issue Oct 23, 2020 · 1 comment · Fixed by #4405
Closed

Updating channel delivery options diff logic needs work #4375

vaikas opened this issue Oct 23, 2020 · 1 comment · Fixed by #4405
Labels
area/channels kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.19.0

Comments

@vaikas
Copy link
Contributor

vaikas commented Oct 23, 2020

Describe the bug
Currently, and in here:
#4359 (comment)

we store two functions which makes it very hard (if not impossible) to determine if delivery functions have differed because the original args are not stored away. This means that for some changes we do not update the delivery options. We should probably store the arguments along for the ride (as well as create the closures) so that we can figure out if things have changed.

Expected behavior
Changes to channel delivery options should be reflected at runtime.

To Reproduce
Steps to reproduce the behavior.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority
@vaikas vaikas added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2020
@vaikas vaikas mentioned this issue Oct 23, 2020
Merged
@grantr grantr added area/channels priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 26, 2020
@grantr grantr modified the milestones: Backlog, v0.19.0 Oct 26, 2020
@grantr
Copy link
Contributor

grantr commented Oct 26, 2020

IIUC, this means delivery spec is not properly reconciled in IMC. We haven't had any complaints about it though.

@vaikas vaikas mentioned this issue Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/channels kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging a pull request may close this issue.

fix issue 4375 vaikas/eventing
2 participants
@grantr @vaikas