Use shared observability config in broker data plane #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to watch the shared config configmaps in knative-eventing.
Broker data plane pods live in the Broker namespace, but observability config lives in the system namespace (knative-eventing). When auto-creating a default Broker and its RBAC, also create a RoleBinding allowing read access to the shared config. The existing permission to read configmaps in the Broker's namespace is retained.
Switch to watching the shared configmaps instead of per-namespace configmaps. This will be easier to manage for the operator and more predictable for the user.
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
approved
|
/milestone v0.7.0 |
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
grantr
added a commit
to grantr/docs
that referenced
this pull request
Jun 19, 2019
These were added in knative/eventing#1426.
knative-prow-robot
pushed a commit
to knative/docs
that referenced
this pull request
Jun 20, 2019
* Add new RoleBindings to broker manual setup These were added in knative/eventing#1426. * Remove commands added by accident
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Sep 29, 2021
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1416
Proposed Changes
knative-eventing) instead of the Broker's namespace. This removes the ability to create per-namespace configs, but we think that use case is much less likely than the cluster-wide config case.SYSTEM_NAMESPACEenv var to ingress and filter podspecs to inform knative/pkg where the system namespace is.Release Note