Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the propagation of Choice address #1611

Merged
merged 1 commit into from Jul 31, 2019
Merged

fix the propagation of Choice address #1611

merged 1 commit into from Jul 31, 2019

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • fix the propagation of Choice address

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 31, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2019
@lionelvillard
Copy link
Member Author

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 31, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1alpha1/choice_lifecycle.go 98.3% 98.3% -0.0

@lionelvillard
Copy link
Member Author

/retest

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@knative-prow-robot knative-prow-robot merged commit 4005ecf into knative:master Jul 31, 2019
@lionelvillard lionelvillard deleted the fix-choice-address branch January 20, 2020 14:59
pierDipi added a commit to pierDipi/eventing that referenced this pull request Feb 14, 2022
@pierDipi
Make SubscriptionSpec.Delivery mutable (knative#1611)
ed5967b 
Just by creating a subscription in v0.24 and upgrading the cluster to
0.26, the webhook starts throwing errors like this:
```
admission webhook "validation.webhook.eventing.knative.dev" denied the request: validation failed: Immutable fields changed (-old +new): spec
{v1.SubscriptionSpec}.Delivery.DeadLetterSink.Ref.Namespace:
    -: ""
    +: "kc-broker-v1-dlq"
```

In addition, Subscription.Spec.Delivery wasn't meant to be immutable,
in fact, TriggerSpec.Spec.Delivery is mutable.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lionelvillard @knative-metrics-robot @n3wscott @knative-prow-robot @googlebot