Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s deps to v0.23.4 #6280

Merged
merged 4 commits into from Mar 18, 2022
Merged

Bump k8s deps to v0.23.4 #6280

merged 4 commits into from Mar 18, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Mar 18, 2022 •
edited

See knative/pkg#2458

See individual commits for details.

Proposed Changes

  • Bump k8s deps to v0.23.4

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

The minimum Kubernetes version is 1.22.

@pierDipi
go get -u knative.dev/pkg@main && hack/update-codegen.sh
cb19129 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fix errors, Probe -> ProberHandler
48cde39 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited

Codecov Report

Merging #6280 (15f0641) into main (2233333) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6280   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files         231      231           
  Lines        7786     7786           
=======================================
  Hits         6399     6399           
  Misses        937      937           
  Partials      450      450
Impacted Files Coverage Δ
...ciler/apiserversource/resources/receive_adapter.go 93.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2233333...15f0641. Read the comment docs.

@pierDipi
Bump Go to 1.17 since it's required
1a3d23a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

/kind api-change

@knative-prow-robot knative-prow-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 18, 2022
@pierDipi
Drop k8s 1.21 from KinD e2e tests
15f0641 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

/test pull-knative-eventing-upgrade-tests

@dprotaso
Copy link
Member

/lgtm
/approve

If your e2e scripts spin up 1.21 clusters you'll want to bump those to 1.22 in a subsequent PR - I haven't bumped the hard min check in pkg yet. Figured I'd give folks time to get these dependency updates through first

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5df47e1 into knative:main Mar 18, 2022
@pierDipi pierDipi deleted the bump-pkg branch March 21, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierDipi @dprotaso @knative-prow-robot