Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on signing and attestation for serving #288

Merged
merged 3 commits into from Dec 19, 2023

Conversation

evankanderson
Copy link
Member

Which issue(s) this PR fixes:

Fixes #287

I think there's something in the environment overrides that caused .base.yaml to not apply for Serving, but this seems to have fixed it. I assumed we'd want any further patch releases on the existing lines to get signatures + attestations, so I updates the existing releases as well.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@upodroid
Copy link
Member

upodroid commented Dec 4, 2023

Can you update the codegen please?

I'll comment on the security audit PR with more info on this.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2023
@evankanderson
Copy link
Member Author

Updated, sorry I missed your comment earlier.

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link

knative-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@knative-prow knative-prow bot merged commit f5eb510 into knative:main Dec 19, 2023
18 checks passed
Copy link

knative-prow bot commented Dec 19, 2023

@evankanderson: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Fixes #287

I think there's something in the environment overrides that caused .base.yaml to not apply for Serving, but this seems to have fixed it. I assumed we'd want any further patch releases on the existing lines to get signatures + attestations, so I updates the existing releases as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serving images (only) do not seem to have attestation information.
3 participants