Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end traces from queue proxy #3898

Closed
mdemirhan opened this issue Apr 25, 2019 · 9 comments · Fixed by #4272
Assignees
Milestone

Comments

@mdemirhan
Copy link
Member

@mdemirhan mdemirhan commented Apr 25, 2019

/area monitoring

We used to rely on Istio proxy and Istio proxy was taking care of sending end to end traces to Zipkin/Jaeger. However; Istio proxy is now an optional thing and doesn't come enabled in all setups. We should evaluate sending end to end traces from queue proxy when Istio proxy is not enabled.

@beemarie

This comment has been minimized.

Copy link
Contributor

@beemarie beemarie commented May 1, 2019

I can start looking into this one.

@mdemirhan

This comment has been minimized.

Copy link
Member Author

@mdemirhan mdemirhan commented May 3, 2019

/assign @beemarie

@knative-prow-robot

This comment has been minimized.

Copy link

@knative-prow-robot knative-prow-robot commented May 3, 2019

@mdemirhan: GitHub didn't allow me to assign the following users: beemarie.

Note that only knative members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @beemarie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdemirhan

This comment has been minimized.

Copy link
Member Author

@mdemirhan mdemirhan commented May 3, 2019

@beemarie, you need to join to knative members before we can assign this to you.

@beemarie

This comment has been minimized.

Copy link
Contributor

@beemarie beemarie commented May 8, 2019

Based on the roles, these are the requirements to be a member, and get items assigned:
https://github.com/knative/docs/blob/master/contributing/ROLES.md#role-summary

I wouldn't say I'm a "regular, active member of the community" yet. It does seem like we should be able to assign issues to collaborators though, right?

@mdemirhan

This comment has been minimized.

Copy link
Member Author

@mdemirhan mdemirhan commented May 10, 2019

I agree with that. It allows assigning issues to repo collaborators, but I dont know how you get to be a repo collaborator. @mchmarny @mattmoor any ideas?

@beemarie

This comment has been minimized.

Copy link
Contributor

@beemarie beemarie commented Jun 4, 2019

Still working through this one -- I want the queue proxy to have access to the tracing config map, so that it can listen and make any required updates. (Similar to how this is done in the activator)

I don't have access to the config map, since it's in a different namespace:
E0603 21:47:22.819629 1 reflector.go:134] k8s.io/client-go/informers/factory.go:131: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:default:default" cannot list resource "configmaps" in API group "" in the namespace "knative-serving"

Was speaking with @greghaynes, and he suggested that one option is to do something similar to what we do for logging -- convert the config to env vars and inject those.
https://github.com/knative/serving/blob/master/pkg/reconciler/revision/resources/queue.go#L231

Does this sound like a reasonable approach @mdemirhan @mattmoor?

@markusthoemmes

This comment has been minimized.

Copy link
Contributor

@markusthoemmes markusthoemmes commented Jun 4, 2019

@beemarie to me at least it does. Accessing the configmap as you pointed out is no good as the pod would need elevated rights to do that.

@markusthoemmes

This comment has been minimized.

Copy link
Contributor

@markusthoemmes markusthoemmes commented Jul 16, 2019

/assign @beemarie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.