Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use networking helpers in AutoTLS tests instead of copying them #10052

Merged

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

As per title, these seem to be straight up duplicates.

Release Note

NONE

/assign @nak3 @tcnghia

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 6, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #10052 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10052      +/-   ##
==========================================
+ Coverage   87.98%   88.01%   +0.02%     
==========================================
  Files         184      185       +1     
  Lines        8663     8683      +20     
==========================================
+ Hits         7622     7642      +20     
+ Misses        794      793       -1     
- Partials      247      248       +1     
Impacted Files Coverage Δ
pkg/reconciler/domainmapping/reconciler.go 85.18% <0.00%> (-0.53%) ⬇️
pkg/reconciler/route/domains/domains.go 100.00% <0.00%> (ø)
.../reconciler/domainmapping/resources/domainclaim.go 100.00% <0.00%> (ø)
pkg/activator/net/revision_backends.go 91.40% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47f121...3cb9de0. Read the comment docs.

@nak3
Copy link
Contributor

nak3 commented Nov 6, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@knative-prow-robot knative-prow-robot merged commit 928286c into knative:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants