Use spec.Namespace to prevent collisions rather than ownerRef #10503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #10503 +/- ##
==========================================
+ Coverage 88.06% 88.08% +0.02%
==========================================
Files 187 187
Lines 8855 8865 +10
==========================================
+ Hits 7798 7809 +11
Misses 817 817
+ Partials 240 239 -1
Continue to review full report at Codecov.
|
|
/test pull-knative-serving-istio-stable-no-mesh |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/retest |
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jan 21, 2021
…e#10503) * Bump deps * Use spec.Namespace to prevent collisions rather than ownerRef * one import path to rule them all
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jan 21, 2021
…e#10503) * Bump deps * Use spec.Namespace to prevent collisions rather than ownerRef * one import path to rule them all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10477.
Proposed Changes
IsControlledBy(which was never actually supported cross-namespace 🙊).Release Note
/assign @tcnghia @mattmoor