Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging to background digest resolver #11959

Merged
merged 1 commit into from Sep 9, 2021

Conversation

julz
Copy link
Member

@julz julz commented Sep 9, 2021

We spent a while tracking down a slow revision reconciler and, while it didn't turn out to be related to background digest resolution in the end, we could have determined that a lot faster if we'd had these logs in there.

Release Note

Adds more debug logs to background digest resolver

/assign @markusthoemmes

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #11959 (18d1490) into main (cc19d71) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11959      +/-   ##
==========================================
+ Coverage   87.64%   87.66%   +0.02%     
==========================================
  Files         197      197              
  Lines        9521     9529       +8     
==========================================
+ Hits         8345     8354       +9     
  Misses        909      909              
+ Partials      267      266       -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 91.26% <87.50%> (-0.41%) ⬇️
pkg/reconciler/revision/revision.go 88.05% <100.00%> (+0.18%) ⬆️
pkg/autoscaler/scaling/multiscaler.go 87.27% <0.00%> (-1.82%) ⬇️
pkg/activator/net/revision_backends.go 92.41% <0.00%> (+0.89%) ⬆️
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc19d71...18d1490. Read the comment docs.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4fcaa97 into knative:main Sep 9, 2021
salaboy pushed a commit to salaboy/serving that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants