Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format markdown #2603

Conversation

mattmoor-sockpuppet
Copy link
Contributor

Produced via: prettier --write $(find -name '*.md' | grep -v vendor)

Produced via: `prettier --write $(find -name '*.md' | grep -v vendor)`
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2018
@mattmoor
Copy link
Member

mattmoor commented Dec 1, 2018

/assign @evankanderson
/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2018
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Some small nits to clean up, and we should do another run with --proseWrap=always to enforce consistent wrapping.

docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
docs/spec/errors.md Outdated Show resolved Hide resolved
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor-sockpuppet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
Remove bad `---` autoformats

Co-Authored-By: mattmoor-sockpuppet <32418083+mattmoor-sockpuppet@users.noreply.github.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@evankanderson
Copy link
Member

I signed it!

@evankanderson
Copy link
Member

(Or at least got my main GitHub account's email marked as signed.)

@evankanderson
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2018
@mattmoor mattmoor merged commit 783b658 into knative:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants