Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest test-infra #2932

Merged
merged 5 commits into from Jan 19, 2019
Merged

Update to latest test-infra #2932

merged 5 commits into from Jan 19, 2019

Conversation

srinivashegde86
Copy link
Contributor

@srinivashegde86 srinivashegde86 commented Jan 18, 2019 •
edited by adrcunha

This adds:

  • Default build and unit test runners. We will be using the default ones in serving and deleting serving runners
  • Save cluster metadata after cluster is created for all tests. Remove the perf specific metadata.
  • Updated release.sh due to breaking changes in the helper

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2019
adrcunha
adrcunha suggested changes Jan 18, 2019
View reviewed changes
test/presubmit-tests.sh Outdated Show resolved Hide resolved
test/release.sh Outdated Show resolved Hide resolved
test/release.sh Outdated Show resolved Hide resolved
@adrcunha
Copy link
Contributor

/assign @mattmoor

@adrcunha
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2019
@mattmoor
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, mattmoor, srinivashegde86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2019
@knative-prow-robot knative-prow-robot merged commit f345429 into knative:master Jan 19, 2019
@srinivashegde86 srinivashegde86 deleted the test-infra branch February 12, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrcunha adrcunha adrcunha approved these changes

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@mattmoor mattmoor

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srinivashegde86 @adrcunha @mattmoor @knative-prow-robot