Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Generation / ObservedGeneration checks before propagating readiness. #4185

Merged
merged 1 commit into from May 30, 2019
Merged

Add Generation / ObservedGeneration checks before propagating readiness. #4185

merged 1 commit into from May 30, 2019

Conversation

mattmoor
Copy link
Member

Fixes: #4149

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 30, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels May 30, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/service_lifecycle.go 97.1% 92.1% -5.0
pkg/reconciler/service/service.go 89.5% 88.7% -0.8

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/service_lifecycle.go 97.1% 92.1% -5.0
pkg/reconciler/service/service.go 89.5% 88.7% -0.8

vagababov
vagababov reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
@knative-prow-robot knative-prow-robot merged commit 11e549d into knative:master May 30, 2019
joshrider pushed a commit to joshrider/serving that referenced this pull request Jun 10, 2019
@mattmoor @joshrider
Add Generation / ObservedGeneration checks before propagating readine…
2ea9e0c 
…ss. (knative#4185)

Fixes: knative#4149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@dgerd dgerd Awaiting requested review from dgerd

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

status.observedGeneration updates without updating the rest of status
6 participants
@mattmoor @knative-prow-robot @knative-metrics-robot @vagababov @dprotaso @googlebot