Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use user-defined readinessProbe in queue-proxy #4731
NOTE: for the activator's probe, we are using the same count of "successful probes" as the pod's usual readiness probe. That is, if the activator and "kubelet" are both probing concurrently and the probe's SuccessThreshold is 4, they will only need 4 consecutive successes collectively (as opposed to 4 each). Please poke holes in this.
So there's good news and bad news.
Note to project maintainer: This is a terminal state, meaning the
knative-prow-robot left a comment
@joshrider: 0 warnings.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
markusthoemmes left a comment
A few flyby comments. I have a really hard time keeping track of what calls what, which probes go where and which retries are applied at which spots.
Do you mind drawing a picture of where we want to apply which retry? The nested retrying feels a little odd to me, maybe there's room for an interim change there as well as this PR is pretty big.
Thanks for doing this though, this is great stuff
Signed-off-by: Shash Reddy <firstname.lastname@example.org> Co-authored-by: Shash Reddy <email@example.com>
- merge logic for knative probes and user defined probes - use probe-period as argument name - pass probe as environment variable instead of container args Signed-off-by: Shash Reddy <firstname.lastname@example.org>
I think things largely look good. Going to give others a chance to leave comments, but if nothing comes up I'll do a final pass later so we can get this baking. It may be worth checking out the data race failure above, since this PR touches the queue logic. thanks for all the work leading up to this!
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing