New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate ingress label from route label #5467
Conversation
This patch changes to propagate ingress's labels from parent Route's label. fixes knative#5462
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nak3: 0 warnings.
In response to this:
Proposed Changes
This patch changes to propagate ingress's labels from parent Route's label.
Fixes #5462
/lint
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test pull-knative-serving-unit-tests |
@nak3 do we already filter out |
@tcnghia Oh, Nice catch! ingress does not have the filter for |
The following is the coverage report on pkg/.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following jobs failed due to test flakiness:
Automatically retrying... |
Proposed Changes
This patch changes to propagate ingress's labels from parent Route's label.
Fixes #5462
/lint
Release Note