Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate ingress label from route label #5467

Merged
merged 3 commits into from Sep 11, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Sep 10, 2019

Proposed Changes

This patch changes to propagate ingress's labels from parent Route's label.

Fixes #5462

/lint

Release Note

NONE

This patch changes to propagate ingress's labels from parent Route's label.

fixes knative#5462
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

Proposed Changes

This patch changes to propagate ingress's labels from parent Route's label.

Fixes #5462

/lint

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor Author

nak3 commented Sep 10, 2019

/test pull-knative-serving-unit-tests

@tcnghia
Copy link
Contributor

tcnghia commented Sep 10, 2019

@nak3 do we already filter out kubectl last-applied label? It's possible to create Route directly, hence possible to have that.

@nak3
Copy link
Contributor Author

nak3 commented Sep 10, 2019

@tcnghia Oh, Nice catch! ingress does not have the filter for last-applied. But it is annotation, not label. So, I will file separate PR with the unit tests.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/resources/ingress.go 79.7% 84.7% 5.1

@tcnghia
Copy link
Contributor

tcnghia commented Sep 11, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Sep 11, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@knative-test-reporter-robot

The following jobs failed due to test flakiness:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests
2/3

Automatically retrying...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit efc358f into knative:master Sep 11, 2019
@nak3 nak3 deleted the ingress-route branch September 11, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress should receive labels from Service/Route
7 participants