Use proper error for missing field for pobe #5713
Conversation
When livenessProbe or readinessProbe missed one of `exec`, `httpGet`
or `tcpSocket`, it gives `ErrMissingField("handler")`. But the
`handler` field does not exist actually (please see `$ kubectl explain
pod.spec.containers.livenessProbe`).
Hence, this patch changes the error to `apis.ErrMissingOneOf`.
knative-prow-robot
added
size/XS
There was a problem hiding this comment.
@nak3: 0 warnings.
In response to this:
Proposed Changes
When livenessProbe or readinessProbe missed one of probes, it gives
ErrMissingField("handler"). But actually thehandlerfield does not
exist in the spec -pod.spec.containers.livenessProbe.This patch changes the error to
apis.ErrMissingOneOf./lint
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor, nak3, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Proposed Changes
When livenessProbe or readinessProbe missed one of probes, it gives
ErrMissingField("handler"). But actually thehandlerfield does notexist in the spec -
pod.spec.containers.livenessProbe.This patch changes the error to
apis.ErrMissingOneOf./lint
Release Note