From 6cda57e16ed66a4d9c0f4734d93c280ea2645361 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Sun, 25 Jul 2021 09:43:40 -0700 Subject: [PATCH 1/2] Require that spec.subscriber is set for Subscription. --- specs/eventing/control-plane.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/specs/eventing/control-plane.md b/specs/eventing/control-plane.md index dd36546f6..498a3b47b 100644 --- a/specs/eventing/control-plane.md +++ b/specs/eventing/control-plane.md @@ -230,11 +230,9 @@ condition MUST indicate the reason for the error. The Subscription MUST also set `status.physicalSubscription` URIs to the empty string if the corresponding `spec` reference cannot be resolved. -At least one of `spec.subscriber` and `spec.reply` MUST be set; if only -`spec.reply` is set, the behavior is equivalent to setting `spec.subscriber` -except that the Channel SHOULD NOT -[advertise the ability to process replies](data-plane.md#derived-reply-events) -during the delivery. +The `spec.subscriber` destination MUST be set; if the `spec.reply` field is not +set, [replies](data-plane.md#derived-reply-events) from the `spec.subscriber` +are discarded. Once created, the Subscription's `spec.channel` MUST NOT permit updates; to change the `spec.channel`, the Subscription MUST be deleted and re-created. This @@ -651,7 +649,7 @@ resource. The `apiVersion` is `messaging.knative.dev/v1` and the `kind` is subscriber - duckv1.Destination
(OPTIONAL) + duckv1.Destination
(REQUIRED) The destination for event delivery. From 41e1c016aba2eb0c3b1d717a98fff53719dd9502 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Thu, 2 Sep 2021 11:54:00 -0700 Subject: [PATCH 2/2] Clarify MUST on discard, thanks Doug --- specs/eventing/control-plane.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/eventing/control-plane.md b/specs/eventing/control-plane.md index b1e10bfe6..735b0c955 100644 --- a/specs/eventing/control-plane.md +++ b/specs/eventing/control-plane.md @@ -232,7 +232,7 @@ condition MUST indicate the reason for the error. The Subscription MUST also set The `spec.subscriber` destination MUST be set; if the `spec.reply` field is not set, [replies](data-plane.md#derived-reply-events) from the `spec.subscriber` -are discarded. +MUST be discarded. Once created, the Subscription's `spec.channel` MUST NOT permit updates; to change the `spec.channel`, the Subscription MUST be deleted and re-created. This