Fix kneath/kss#39 #40

Merged
merged 3 commits into from Aug 2, 2012

Conversation

Projects
None yet
4 participants
Contributor

alanhogan commented Jun 4, 2012

Should make the pseudo-element selector display work with @extends.

I didn’t see any relevent tests, but this test input could be useful.

/*
Nothing much. It has no border but it has focus styles

:focus - Focus state

Styleguide 2.3.1
*/
.foo {
  border-width: 0;
}
.foo:focus, .foo-variant:focus {
  outline: 3px solid rgba(0,80,255, 0.4);
}

/*
Like foo, but fullwidth.

:focus - Focus state

Styleguide 2.3.2
*/
.foo-variant {
  width: 100%;
}

See kneath/kss#39

Contributor

alanhogan commented Jun 11, 2012

Just wanted to say that this fix does indeed work for me, and that the impatient can use it via a gem install kss-alan.

Contributor

alanhogan commented Jul 30, 2012

Anything I can do to get this merged in?

Owner

kneath commented Aug 2, 2012

Rad, I'm cutting a new gem today. I'll get it out.

kneath pushed a commit that referenced this pull request Aug 2, 2012

@kneath kneath merged commit a758afc into kneath:master Aug 2, 2012

Experienced an interesting issue with this change today. We're seeing Chrome lockup with this code around pseudo selectors (specifically line 21 where it attempts the replace) but not on other browsers. We reverted to the code just prior to this change and all is working well. Anyone else experiencing this issue? I'm happy to make a gist with a test example if others aren't able to replicate it.

@sumitngupta 👍 I am also experiencing a Chrome lockup issue with this script.

I have previously used the older version, but today decided to switch to the latest version. I reverted back to the previous version, too. But since the older version works okay, it's okay, for now :)

Contributor

alanhogan commented Aug 4, 2012

Which version of Chrome? Bug in their regex handling?

Owner

kneath commented Aug 4, 2012

@sumitngupta An example would be great, it's been working great on Chrome for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment