Use only the stylesheets with the correct endings. #50

Merged
merged 1 commit into from Jun 17, 2013

Conversation

Projects
None yet
4 participants
Contributor

raskhadafi commented Nov 27, 2012

I had an error who was caused by an image file in the stylesheets folder.

Use only the stylesheets with the correct endings.
I had an error who was caused by an image file in the stylesheets folder.

image file in the stylesheets folder.

Found the error.

Contributor

raskhadafi commented Jan 16, 2013

What about a merge?
The gem would be more stable.

I got "invalid byte sequence in UTF-8" exception until I found it was caused by binary files in stylesheets/ (got answer here: dewski/kss-rails#14).

This patch is definitely useful to me.

Collaborator

benschwarz commented Jun 13, 2013

@raskhadafi — Why don't you add an image or some invalid file to the test suite? That way the change is documented as actually fixing something, rather than tweaking a random path.

Collaborator

benschwarz commented Jun 17, 2013

I've added an example image to the test suite.
Merging.

benschwarz added a commit that referenced this pull request Jun 17, 2013

Merge pull request #50 from raskhadafi/patch-1
Use only the stylesheets with the correct endings.

@benschwarz benschwarz merged commit e743087 into kneath:master Jun 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment