Adds styleguide-html wrapper around example code #51

Merged
merged 1 commit into from Jun 15, 2013

Conversation

Projects
None yet
2 participants
Contributor

janiv commented Jan 3, 2013

The _styleguide_block.erb appears to have been missing the
styleguide-html wrapper around the styleguide-code pre element.
The missing wrapper results in the code example being poorly
laid out and visually unappealing.

Adds the wrapper around the element. This corrects the display
and looks more as expected from the example screenshots on
http://warpspire.com/kss/styleguides/

Adds styleguide-html wrapper around example code
The _styleguide_block.erb appears to have been missing the
styleguide-html wrapper around the styleguide-code pre element.
The missing wrapper results in the code example being poorly
laid out and visually unappealing.

Adds the wrapper around the element. This corrects the display
and looks more as expected from the example screenshots on
http://warpspire.com/kss/styleguides/
Collaborator

benschwarz commented Jun 15, 2013

Nice catch.
Next time to make the change easier to review, it'd be great if you could take a before and after screenshot.

Thanks for the fix!

benschwarz added a commit that referenced this pull request Jun 15, 2013

Merge pull request #51 from janiv/styleguideCodeBlockFix
Adds styleguide-html wrapper around example code

@benschwarz benschwarz merged commit 6232a82 into kneath:master Jun 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment